search

KosinskiLab / AlphaPulldown

https://doi.org/10.1093/bioinformatics/btac749
GNU General Public License v3.0
199 stars 46 forks source link

Use DEFINE_list for model_names flag #362

Closed DimaMolod closed 3 months ago

DimaMolod commented 3 months ago

We need to change 'model_names' flag from DEFINE_string to DEFINE_list here https://github.com/KosinskiLab/AlphaPulldown/blob/main/alphapulldown/scripts/run_structure_prediction.py#L50-L51

and remove manual splitting in alphafold_backend here: https://github.com/KosinskiLab/AlphaPulldown/blob/main/alphapulldown/folding_backend/alphafold_backend.py#L180-L183

dingquanyu commented 3 months ago

Do NOT remove the splitting in the manual because DEFINE_list takes comma separated strings from the command line.

DimaMolod commented 3 months ago

@dingquanyu, why do you need to split by coma if DEFINE_list already takes comma-separated strings?

dingquanyu commented 3 months ago

oh I thought you mean remove the comma separated string from the manual