search

KosinskiLab / AlphaPulldown

https://doi.org/10.1093/bioinformatics/btac749
GNU General Public License v3.0
199 stars 46 forks source link

Fix 362 #371

Closed dingquanyu closed 3 months ago

dingquanyu commented 3 months ago
  1. change "model_names" to "DEFINE_list"
  2. make AlphaPulldown compatible with old versions of AlphaFold Multimer
dingquanyu commented 3 months ago

Hold on somehow my AlphaFold_backend.py does not have the new commits from the previous merge

DimaMolod commented 3 months ago

exactly, there seems to be no convert_to_modelcif flag for run_prediction and the corresponding execution part in the postprocessing is missing...also the resume fix we did on Mondaz

dingquanyu commented 3 months ago

exactly, there seems to be no convert_to_modelcif flag for run_prediction and the corresponding execution part in the postprocessing is missing...also the resume fix we did on Mondaz

yea that's so weird, especially because I branched out only after pulling the latest main branch. I think now it's fine. Running the tests right now

dingquanyu commented 3 months ago

exactly, there seems to be no convert_to_modelcif flag for run_prediction and the corresponding execution part in the postprocessing is missing...also the resume fix we did on Mondaz

Yep the tests are finished. I believe it's safe to merge

dingquanyu commented 3 months ago

you tested all three possibilities, right?

  1. model_names_custom =
  2. model_names_custom=
  3. model_names_custom = None

Yea that's right