KoslickiLab / YACHT

A mathematically characterized hypothesis test for organism presence/absence in a metagenome
MIT License
28 stars 7 forks source link

Integrate the `yacht sketch` functions #90

Closed chunyuma closed 7 months ago

codecov[bot] commented 8 months ago

Codecov Report

Attention: 65 lines in your changes are missing coverage. Please review.

Comparison is base (15e943a) 80.30% compared to head (be87df4) 77.65%.

Files Patch % Lines
yacht/sketch_ref_genomes.py 35.18% 35 Missing :warning:
yacht/sketch_sample.py 40.00% 30 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #90 +/- ## ========================================== - Coverage 80.30% 77.65% -2.66% ========================================== Files 21 23 +2 Lines 1488 1602 +114 ========================================== + Hits 1195 1244 +49 - Misses 293 358 +65 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

chunyuma commented 8 months ago

Hi @dkoslicki @mfl15, this PR just adds two scripts created by Andreas for sketching genomes and samples. It doesn't affect anything. A few more changes are needed to integrate them into yacht (e.g., yacht sketch). You can now approve this PR to merge it into main. Or You can wait until I have successfully made them work in the next few weeks.

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud