search

KosmX / minecraftPlayerAnimator

Minecraft 1.16+ player animation library
https://modrinth.com/mod/playeranimator
MIT License
79 stars 19 forks source link

[API] Easings don't work on GeckoLib animations. #112

Open ZigyTheBird opened 1 month ago

ZigyTheBird commented 1 month ago

Describe the bug The mod successfully reads the easings it's supposed to use on each keyframe and stores it in the appropiate KeyFrame class instances but for some reason in-game linear ease is always used instead of the intended easing. This problem seems to not occur with Blender animations. Here is a discord post with the original person that found this bug: https://discord.com/channels/737216980095991838/1285522357573914664 OP may have also found a bug related to bending: https://discord.com/channels/737216980095991838/1285522357573914664/1285600739787276348

To Reproduce Steps to reproduce the behavior:

  1. Play a GeckoLib animation with easings
  2. See linear easing being used regardless of the intended easing

Setup config (minecraft, modloader, libraries): I tested this on a fork of the 1.21 branch of this very mod but it seems to occur on 1.20.1 as well even without any other libraries or mods involved. Things broke way less on my 1.21 branch than in OP's 1.20.1 dev environment though.

dima-dencep commented 1 month ago

It works, but in a different way

ZigyTheBird commented 1 month ago

@dima-dencep what do you mean by that?

dima-dencep commented 1 month ago

Easings work, but they look different in game than they do in blockbench, etc

ZigyTheBird commented 1 month ago

TBH I am not really good at telling easings apart :p I showed a clip of me playing some GeckoLib animations to a guy in the afformentioned discord post and he said that the easings were linear Either way this is a problem that's worth addressing

dima-dencep commented 1 month ago

Well, if easings didn't work, your animation would be 20 frames/second