Kosmorro / kosmorro

A program to calculate your ephemerides.
https://kosmorro.space
GNU Affero General Public License v3.0
60 stars 7 forks source link

Make a Docker image #19

Closed Deuchnord closed 3 years ago

Deuchnord commented 4 years ago

Suggested by @Pierstoval on Twitter: create an official Docker image.

nicfb commented 3 years ago

Is this still something you're wanting for Kosmorro? I'd love to give it a try.

Deuchnord commented 3 years ago

Is this still something you're wanting for Kosmorro? I'd love to give it a try.

Yes, it is! Making a Docker image would dramatically simplify the use of the program for the people who want to use it without necessarily install it :)

nicfb commented 3 years ago

I think I have something working. I'm planning on making a PR tomorrow so you can check it out.

Deuchnord commented 3 years ago

Since this can be added to the v0.9 to be released soon, you can base your PR on master directly :)

nicfb commented 3 years ago

Great! What should be included in the commit, just the Dockerfile? And will the image need to be hosted somewhere like Docker Hub? This is my first time working with Docker, so I'm not sure what should be checked into git.

Deuchnord commented 3 years ago

You may update the "installation" section of the Readme, to inform the users about the available image.

And will the image need to be hosted somewhere like Docker Hub? This is my first time working with Docker, so I'm not sure what should be checked into git.

Yes, it will! The image will be named kosmorro/kosmorro. I think you can add this GitHub Action workflow, with execution on tag push :slightly_smiling_face:

nicfb commented 3 years ago

Ok. Sorry the late reply, I haven't had much time to dedicate to this in the past few days. I'm familiarizing myself with GitHub Actions right now, but I think I will have it ready soon.

Deuchnord commented 3 years ago

Don't worry, you have time for this 😉

nicfb commented 3 years ago

I have opened the PR. Please let me know if you see anything that I need to fix.