Closed Deuchnord closed 3 years ago
Is this still something you're wanting for Kosmorro? I'd love to give it a try.
Is this still something you're wanting for Kosmorro? I'd love to give it a try.
Yes, it is! Making a Docker image would dramatically simplify the use of the program for the people who want to use it without necessarily install it :)
I think I have something working. I'm planning on making a PR tomorrow so you can check it out.
Since this can be added to the v0.9 to be released soon, you can base your PR on master
directly :)
Great! What should be included in the commit, just the Dockerfile? And will the image need to be hosted somewhere like Docker Hub? This is my first time working with Docker, so I'm not sure what should be checked into git.
You may update the "installation" section of the Readme, to inform the users about the available image.
And will the image need to be hosted somewhere like Docker Hub? This is my first time working with Docker, so I'm not sure what should be checked into git.
Yes, it will! The image will be named kosmorro/kosmorro
. I think you can add this GitHub Action workflow, with execution on tag push :slightly_smiling_face:
Ok. Sorry the late reply, I haven't had much time to dedicate to this in the past few days. I'm familiarizing myself with GitHub Actions right now, but I think I will have it ready soon.
Don't worry, you have time for this 😉
I have opened the PR. Please let me know if you see anything that I need to fix.
Suggested by @Pierstoval on Twitter: create an official Docker image.