search

Kosmorro / lib

Kosmorrolib, a library to calculate ephemerides.
https://kosmorro.space/lib
GNU Affero General Public License v3.0
7 stars 6 forks source link

Use skyfield-data to get the needed files #4

Closed thierry-FreeBSD closed 3 years ago

thierry-FreeBSD commented 3 years ago

As noted in readme, "the first time it runs, Kosmorro will download some important files needed to make the computations". These files (e.g. de421.bsp) could be available after installation of https://github.com/brunobord/skyfield-data (also available from https://pypi.org/project/skyfield-data/ ).

Deuchnord commented 3 years ago

Interesting. I didn't know this package and it could definitely be a good alternative to downloading data from NASA's servers.

I was actually thinking about switching to Skyfield's built-in data (with the builtin=True parameter), but maybe this package is actually better?

@brandon-rhodes maybe we could get some advice about this? ^_^

brandon-rhodes commented 3 years ago

The builtin parameter only controls whether the Timescale downloads Earth rotation files, as those were small enough to justify including in Skyfield itself. But Skyfield includes no JPL ephemeris files, as it would, alas, make Skyfield dozens of megabytes in size.

github-actions[bot] commented 3 years ago

This issue has not been active since a lot of time. If you think it is still valid, feel free to reply with a simple comment. Without any update, I will close it in 7 days.

thierry-FreeBSD commented 3 years ago

This issue has not been active since a lot of time. If you think it is still valid, feel free to reply with a simple comment. Without any update, I will close it in 7 days.

Keep alive.

Deuchnord commented 3 years ago

Closing this issue, feature implemented in #22 for version 1.0.0 :tada: