KosmosisDire / TeammateRevive

A simple Risk of Rain 2 mod that allows teammates to revive their fallen colleagues.
4 stars 9 forks source link

Respawn items (Dio's, Void Heart from Aetherium) still leave a totem #6

Closed gaforb closed 3 years ago

gaforb commented 3 years ago

Totem works and can respawn an already alive player at full health

KosmosisDire commented 3 years ago

You're saying when a player is revived by some other mod, the skull stays and can be used to "revive" a player again even though they are alive?

KosmosisDire commented 3 years ago

Yeah actually that would make sense and I didn't think of that. Once I get the damage numbers and lighting synced over the network, I'll start working on a fix for this. Thank you!

gaforb commented 3 years ago

Happens with both modded and unmodded respawn methods. As a suggestion, maybe a (configurable) timer for how long before the skull / respawn area spawns, which checks a second time that the player is dead?

KosmosisDire commented 3 years ago

I think that would still fail for mods where the player revives after the skull has spawned. I am already looping through each dead player and I can just check if they are still dead each time (Should be a very simple check). If they aren't then I'll just despawn the skull and move them back to the alive players.

KosmosisDire commented 3 years ago

The timer idea though would be good just in general. In case players want there to be a wait, instead of being able to immediately revive other players

KosmosisDire commented 3 years ago

Okay, this should be fixed in the latest update! File another issue if there's still anything wrong :)