[Bug] [1.8.01]: 1.8.01 realease main.js is not same as actual code that was build from clone to local

[martinniee]

What happened?

Hi there, thank you for developing the useful and powerful plugin. I was using the plugin to export but result was not what i expected. So i was tring to manully clone this project to build and it worked for me, but directly install from plugin store did not work. Now i seems to know the reason that is release 1.8.01 main.js code is not same as the result build by cloning it. I consider release 1.8.01 the main.js is not correct. More details about what i have experienced just omit. The reason of it ,I guess when the title is pure number,and do not convert it to type of string, causing title.endWith() is not a function.

But actually the problem have resolved in the version 1.8.01

So you may need to check and update main.js in release 1.8.01

Reproduction

1. install 1.8.01 from plugin store or manully download in 1.8.01 release
2. open a vault, create a note,and set frontmatter as following

---
title: 1
---

ensure title is pure number and not wrapped with "" quote

3. open command palette ,typing Webpage HTML Export: Set html export settings
4. then a blank modal will display

5. press Ctrl + Shift + i to open developer tool, error information will be output

Last Working Version

It works fine with latest version but release main.js

Version

1.8.01

Operating System

Windows 11

Obsidian Version

1.5.3

Which browsers can you reproduce this in?

Chrome

Relevant log output

Log:
[INFO]  Including stylesheet: svelte-1xm87ro
[INFO]  Including stylesheet: svelte-z95de7-style
[INFO]  Including stylesheet: svelte-c8tyih-style
[INFO]  Including stylesheet: svelte-1d9aab-style
[INFO]  Including stylesheet: svelte-4mq5op-style
[INFO]  Including stylesheet: svelte-11amwf8-style
[INFO]  Including stylesheet: svelte-yzawxy

Settings:
    settingsVersion --------- 1.8.01
    makeOfflineCompatible     false
    inlineAssets ------------ false
    includePluginCSS          1 plugins included
    includeSvelteCSS -------- true
    titleProperty             title
    customHeadContentPath ---
    faviconPath              
    documentWidth ----------- 40em
    sidebarWidth              20em
    minOutlineCollapse ------ 2
    startOutlineCollapsed     false
    allowFoldingHeadings ---- true
    allowFoldingLists         true
    allowResizingSidebars --- true
    logLevel                  warning
    minifyHTML -------------- true
    makeNamesWebStyle         true
    onlyExportModified ------ true
    deleteOldFiles            true
    addThemeToggle ---------- true
    addOutline                true
    addFileNav -------------- true
    addSearchBar              true
    addGraphView ------------ true
    addTitle                  true
    addRSSFeed -------------- true
    siteURL                  
    authorName --------------
    vaultTitle                community-plugin-research
    exportPreset ------------ website
    openAfterExport           false
    graphAttractionForce ---- 1
    graphLinkLength           10
    graphRepulsionForce ----- 150
    graphCentralForce         3
    graphEdgePruning -------- 100
    graphMinNodeSize          3
    graphMaxNodeSize -------- 7
    showDefaultTreeIcons      false
    emojiStyle -------------- Native
    defaultFileIcon           lucide//file
    defaultFolderIcon ------- lucide//folder
    defaultMediaIcon          lucide//file-image
    exportPath --------------
    filesToExport             0

Enabled Plugins:
    Divide & Conquer
    Webpage HTML Export

> above is not main reason but still provide

Additional Info

blank modal

error info

[KosmosisDire]

Hi, as far as the actual issue I believe this is fixed in the beta version which you can access using GitHub releases.

As far as the master branch being different, that is likely because people often submit PRs onto the master branch and I merge them into there. If you want to clone the exact code that was used to build 1.8.01 you can simply clone that tag instead

Thanks!

[KosmosisDire]

To clarify, I simply haven't released the next version yet, as it's still in beta and some of those fixes are on that new beta version. So when the next stable version comes out, those fixes will come along with it. And until then people can use the beta version if it fixes they're specific problems

[martinniee]

Thanks for your answer. Now I seems to know what the situation is. As far as i know, Obsidian will pull lastest commit as installed version when installing plugin in Community plugins.

I just checked through two branches . code of Master branch is correct and code of 1.8.01 is still error. So actually branch i cloned is Master not 1.8.01 I mentioned before, which is my mistake.

Now question is when user is installing from Community Plugins in Obsidian app, they will get 1.8.01 version ,and there are bugs still ( included me i installed before) . So just hope to next release stable version as soon as possible.

Thanks again for developing such a powerful plugin. I think the plugin is a lot of work, so I'm not in a hurry to wait for a stable version, and this problem has been solved locally on my own.

[KosmosisDire]

Obsidian's community plugin list pulls the latest release actually, not the latest commit. Which is why it is different. But I'm glad it's working. Thanks!

[martinniee]

Yes,latest release, I made a typing error.