Open spartacus04 opened 1 month ago
Almost ready, the docker container is exporting to HTML successfully, just need to finish the github action and test it a bit, then it'll be ready to be merged.
Amazing! Thank you so much for your work on this!
Just finished this, just remember to setup the DOCKER_USERNAME
and DOCKER_TOKEN
secrets inside the repository settings. Once a new tag is published the github action will start working correctly.
Here's an example on how the github action works:
- name: Obsidian Webpage Export Action
id: obsidian-webpage-export
uses: KosmosisDire/obsidian-webpage-export
with:
vault: ./ #defaults to .
version: latest #optional
config: config.json #optional
- run: |
echo "The export is available at ${{ steps.obsidian-webpage-export.outputs.output }}"
I would advise creating a new tag both for the stable and beta release.
Awesome, this is amazing. I am pretty busy atm but I'll try and take a look at getting this set up today
Hey, I am trying to test this outside of GitHub actions and it seems to all work but I can't get it to actually export specific files. I think the config.json is not being respected somehow, I assume the config.json is meant to be the settings (data.json) from the plugin. When I export I simply get an export as if no files were selected for export. I just get the lib folder and no .html files. Is the config.json being copied into the plugin directory correctly?
Hey, sorry for the late response. I was pretty busy last week. I just pushed a fix to that.
I also remembered, I haven't tested this for the 1.8.1 version, just for the master branch. Since I made some changes to the plugin code itself, for it to work they must also be applied to the other branches.
Thanks I'll test it out again, as far as the other branches I can either copy over the changes or they will be applied when the branch is merged into master.
Goals
What I did so far
DOCKER_USERNAME
andDOCKER_TOKEN
inside repository secrets)Related to
49 #140