search

KosmosisDire / obsidian-webpage-export

Export html from single files, canvas pages, or whole vaults. Direct access to the exported HTML files allows you to publish your digital garden anywhere. Focuses on flexibility, features, and style parity.
https://docs.obsidianweb.net/
MIT License
871 stars 74 forks source link

Highlight attached file in file tree when clicked on in note #475

Open Der-Flip opened 3 months ago

Der-Flip commented 3 months ago

Is your feature request related to a problem? Please describe. Not really a problem: Sifting through an extensive list of files in the file tree to find a specific attachment.

I completely understand that saving something, that is locally stored already, does seem incredibly non-sensical, and I do agree. I am planning to share some notes with my parents though and I know that it would be incredibly cumbersome for them to check the filename, find it in the export's attachment folder and copy-paste it to their preferred location. (tbh, I also think there's other usecases, and it only now that I remember, exporting for online publishing is probably one of them)

Describe the solution you'd like clicking on an attachments (especially attachments that aren't rendered in the note like for instance images) highlights the respective file in the file tree. If the file tree is collapsed maybe even un-collapses the tree to the file path of the file. Highlighting fades away after X seconds (idk, 5-10 or something like that).

Describe alternatives you've considered clicking on attachment opens a prompt whether the file would like to be saved. If confirmed filesystem's "save as" dialog opens or make these attachment-span elements right clickable.

I am super excited for the "noob" mode export mentioned in #460. Maybe this would already make it easier but I do think it would be a nice addition for people, who want to save an attached file separately, to not have to leave the browser...

KosmosisDire commented 3 months ago

Hi, this is already a feature, maybe it is only available in the beta version? There are instructions for using the beta version in the readme if you'd like. But I was pretty sure it already did this.

Der-Flip commented 3 months ago

I tested the beta and it seems it only highlights the note. When clicking an attachment it doesn't do that.

on a side note: something about pdf seems to be broken: in FireFox they are completely ignored, and it doesn't show anything,
in chrome there is a "this plugin is not supported" message.

Further: anything (text, even with multiple paragraphs and files) that a pdf or other non-graphic file is pasted above, below or inline of without an additional empty new line separating the file from the other element is not visible in chrome nor in FireFox (does it get included in the base64 of the pdf?)

same behaviour in stable 1.8.01, happy open new issue if this is unknown

KosmosisDire commented 3 months ago

PDFs are not supported on mobile, there's nothing I can do about that.

I will look into making it work for attachments as well as notes. Thanks!

Der-Flip commented 3 months ago

PDFs are not supported on mobile,

good to know.

Unfortunately the issues with the html exports and the pdf (or other file types) was on desktop firefox and desktop chrome. When inspecting the html for the export of this note, none of the elements surrounding the "Halberstadt - Magdeburg HBX.pdf" appear in the HTML at all. as soon as there is an empty line surrounding the pdf (or other file type), all is good.

I may open a separate ticket with a detailed video on this; that's maybe easier than to explain in text.