search

KostaSav / hp-api

A simple JSON-based API for getting information on Harry Potter characters.
202 stars 86 forks source link

Harry Potter and the Philosopher's Stone Chapter 1: The Boy Who Lived #2

Closed KostaSav closed 3 years ago

KostaSav commented 3 years ago
  1. I have not added pictures, not sure which ones to choose, from where and if that's okay
  2. In case of multiple actors (like Richard Harris and Michael Gambon for Albus Dumbledore), do we write them both? If yes, inside a string using commas?
  3. In case of multiple names (Lily Potter nee Evans, Poppy "Madame" Pomfrey, etc.) do we write them both?
bethfraser commented 3 years ago 
1. I have not added pictures, not sure which ones to choose, from where and if that's okay

2. In case of multiple actors (like Richard Harris and Michael Gambon for Albus Dumbledore), do we write them both? If yes, inside a string using commas?

3. In case of multiple names (Lily Potter nee Evans, Poppy "Madame" Pomfrey, etc.) do we write them both?

  1. I actually don't remember where I got the images from originally. You could have a look to see if there's anywhere to get copyright-free images but it might be difficult!

  2. I think maybe add a 'alternate_actors' key, which could be an array of previous actors, and have 'actor' be the most recent actor in the main HP series - and then alternates could also include any actors from the Fanastic Beasts films. This means that anyone currently using the API won't have it break.

  3. Probably the same as 2, add something like 'alternate_names'.