KostyaSha / github-integration-plugin

Jenkins GitHub Integration Plugin
https://wiki.jenkins-ci.org/display/JENKINS/GitHub+Integration+Plugin
MIT License
97 stars 84 forks source link

Add support for teams in User Restriction #206

Open sebastienvas opened 7 years ago

sebastienvas commented 7 years ago

Currently I am using the restriction for all users in a given org which works well. However we are getting some PRs from people outside the org so I created a team of white listed people however I don't know how to make the plugin understand this.

Another simpler way would also be:

I also enabled the "comment matched to pattern" trigger, it would be easier to check if the user making the comment matches the user restrictions regardless of the author of the PR, that way I would not have to create a white listed group.

sebastienvas commented 7 years ago

Any update on this ?

kknd22 commented 7 years ago

were you able to add adhoc user in the user restriction whitelist and make it work? I doesn't work for me. https://github.com/KostyaSha/github-integration-plugin/issues/233

KostyaSha commented 7 years ago

Sorry, somehow loosing issues/notifications. It's a complex question about permissions where i don't see the best solution. Initially userRestriction was bundled into trigger as security API and container org/user patterns. Event checks (rules) for triggering should call them to check whether it allowed to do something from user. But event itself could do checks and it unclear now what happened. I can add options if we will find some design solution...