search

KostyaSha / github-integration-plugin

Jenkins GitHub Integration Plugin
https://wiki.jenkins-ci.org/display/JENKINS/GitHub+Integration+Plugin
MIT License
98 stars 86 forks source link

Add missing `application/x-www-form-urlencoded` header #382

Closed basil closed 1 year ago

basil commented 1 year ago

See https://github.com/jenkinsci/jenkins/pull/8278. Not strictly necessary, and there is no user-facing issue here, but this PR is done as a code cleanup and to create a consistent coding style throughout the Jenkins project.

This change is Reviewable

KostyaSha commented 1 year ago

Btw tried on fresh jenkins in a new plugin to make a button that should just press and call method with parameter and it didn't work. Looks like js wasn't called at all because jenkins has it's own callback. Could you help understand how to make a row of buttons with different ids that should call java method with @RequirePOST? I tried f.button, but it do redirect, finally f.apply made it, but it has almost inivisible color.

basil commented 1 year ago

I don't know the answer to your question, but in any case it is unrelated to the scope of this PR.

KostyaSha commented 1 year ago

I don't know the answer to your question, but in any case it is unrelated to the scope of this PR.

yeap unrelated, i spent a lot of time checking IRC, gitter, website and fidn't found where is jenkins chat today...

basil commented 1 year ago

https://groups.google.com/group/jenkinsci-dev/topics is still the best place for questions like this I think.

KostyaSha commented 1 year ago

btw more or less it's related. Probably this JS is not need now, i don't know web and jenkins changes well in the UI.

basil commented 1 year ago

Well sure, but whether or not this JavaScript is needed now has nothing to do with the core purpose of this pull request, which is to clean up the existing code and standardize on a common coding style.