updated Dry Run feature

adityakalburgi commented 4 weeks ago

Hi @techy4shri, @Kota-Karthik

Thank you for your feedback! I apologize for not following the PR template initially. I’m currently updating the PR with the required information.

Description

Updated the README.md to clarify project setup instructions. Added a dry run feature in flags.py, which will display the files that would be deleted without actually removing them. This allows users to review the potential deletions before making any changes.

Fixes #58

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation update
[ ] Tests update

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes
[x] I have maintained a clean commit history by using the necessary Git commands
[x] I have checked that my code does not cause any merge conflicts

Screenshots (if applicable)

Screenshot 2024-10-17 194025

Wahid7852 commented 3 weeks ago

Waiting for a response @adityakalburgi. Failure in responding within 24 hours will lead to me closing your PR.

adityakalburgi commented 3 weeks ago

Waiting for a response @adityakalburgi. Failure in responding within 24 hours will lead to me closing your PR.

Hi i am soo updating the PR thank you..

Kota-Karthik commented 3 weeks ago

@adityakalburgi I noticed something about your PR I think you hadn't pulled changes before making changes Which will cause problems So i request you to pull the changes , then make a PR

adityakalburgi commented 3 weeks ago

Jull sync your fork and pull changes once to ensure you are up-to-date with everything and then we will be happy to merge your PR!

Ok sure will do it soon...

adityakalburgi commented 3 weeks ago

Jull sync your fork and pull changes once to ensure you are up-to-date with everything and then we will be happy to merge your PR!

hi @techy4shri i have sync my fork please have a look thank you!

Wahid7852 commented 2 weeks ago

@Kota-Karthik review ra pls

adityakalburgi commented 2 weeks ago

hi @Kota-Karthik i have updated my PR!

Wahid7852 commented 2 weeks ago

I will say to close this PR, delete your fork of TwinTrim, Then refork the repo, do your changes on the new fork and then submit a new PR

This PR now is looking dirty with so many redundant merges.

Kota-Karthik commented 2 weeks ago

@adityakalburgi If you fail to follow the instructions I gave you on discord I will be closing this PR by EOD tomorrow

adityakalburgi commented 2 weeks ago

@adityakalburgi If you fail to follow the instructions I gave you on discord I will be closing this PR by EOD tomorrow

I will create a new PR so you can close this one

Kota-Karthik / twinTrim