search

Kotaimen / awscfncli

Friendly AWS CloudFormation CLI
MIT License
59 stars 12 forks source link

TerminationProtection is enabled before stack deployment #33

Closed Kotaimen closed 6 years ago

Kotaimen commented 6 years ago

TerminationProtection is enabled before stack creation completes thus if stack deployment failed user. have to manually disable it in the Console.

GlieseRay commented 6 years ago

What is the expected behavior for a failed deployment. 1 turn off the protection and delete the failed stack? 2 just turn off the protection? and let user to delete the stack? 3 add a single command to let user turn off him/herself?

I think we can just turn off the protection since user will need to look up why the deployment failed in the console. and add a new command seems not that necessary.

Kotaimen commented 6 years ago

Turn off protection if deploy fails (or add termination protection after deployment succeeded)