KotatsuApp / Kotatsu

Manga reader for Android
https://kotatsu.app
GNU General Public License v3.0
4.04k stars 176 forks source link

Changes to the way progress is tracked/shown #1105

Open Prutosaurus opened 1 month ago

Prutosaurus commented 1 month ago

Describe your suggested feature

So ever since I started using the App it had problems showing th progress accurately, so I'd like to ask the devs to change the way it's calculated if possible(I'm not good at the programming side, but believe the weird progress tracking is due to the formulas used to calculate it), or if not possible add a function to show chapters read out of available chapters instead of the checkmark, (i.e show (12/3456) in the corner) I really hope for something like this to be added since it becomes hard to keep track of what you've and what not when it ignores 5 unread chapter with larger mangas and show them as completed, thanks.

Acknowledgements

MariusAlbrecht commented 1 week ago

Please provide specific steps to reproduce. It's not clear imo what your issue is.

Prutosaurus commented 1 week ago

Hi what I want fixed would be this Screenshot_2024-10-14-16-37-16-418_org koitharu kotatsu Screenshot_2024-10-14-16-37-21-659_org koitharu kotatsu-edit As you can see in the picture there clearly are more chapters to read, but in the browser it's marked completed. As I said it's not the worst, but it gets annoying when you have a lot of titles saved

MariusAlbrecht commented 1 week ago

I understand now. It seems like the app considers anything above 99.5% progress as completed.

https://github.com/KotatsuApp/Kotatsu/blob/devel/app%2Fsrc%2Fmain%2Fkotlin%2Forg%2Fkoitharu%2Fkotatsu%2Flist%2Fdomain%2FReadingProgress.kt#L41 const val PROGRESS_COMPLETED = 0.995f

Imo that should be 100%. Does the app only showing the checkmark on 100% progress (showing 99% otherwise) align with your expectations?

Prutosaurus commented 1 week ago

Yes, that would be awesome, thank you for all the work