search

KoteiIto / node-athena

a nodejs simple aws athena client
MIT License
105 stars 73 forks source link

concurrency limit #35

Open yanggaosc opened 6 years ago

yanggaosc commented 6 years ago

Thank you for providing this handy library!

I notice that you keep a local counter of calls, and will queue queries when the concurrency limit is hit.

Just curious why? Athena has its own way of queueing, and would not fail the queries either.

Thanks!

Yang

yanggaosc commented 6 years ago

maybe it is for keeping alive a line of super long queries that would take more than 30 minutes, which is the AWS athena default timeout?

KoteiIto commented 6 years ago

I thought that errors will be returned from aws sdk when the service limit is exceeded.

https://docs.aws.amazon.com/athena/latest/ug/service-limits.html

Is there documentation about Athena queuing query?

yanggaosc commented 6 years ago

seems that the concurrency limit is per server? what if I have 100 servers running your library?

yang