search

KoteiIto / node-athena

a nodejs simple aws athena client
MIT License
105 stars 73 forks source link

Upgrading AWS-SDK version to latest #49

Closed dhmachado closed 5 years ago

dhmachado commented 5 years ago

Update AWS-SDK Version to latest v2.444.0 (https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)

We need this to fix this issue: https://github.com/aws/aws-sdk-js/issues/2581, which was fixed on version v2.438.0

dhmachado commented 5 years ago

Hello @KoteiIto , I'm having issues with the CI, it's failing but I cannot see the reason behind that. My change it's only a version upgrade on the AWS-SDK lib. Also created this PR #51 with only a new line on the README and also failed for the same reason. Is this anything that I'm missing on my PR thats producing this error ??

Thanks in advance :)

KoteiIto commented 5 years ago

Thank you for sending a pull request. I also confirmed the same event in #52. The reason CI is failing is that tslint has an error in nodejs v4 and v5 environment. The version of tslint may be affecting it. I do not know the cause yet, but since there is no difference in the javascript source code that has been built, it should work in environments with v4 and v5. The version that tslint fails will be excluded from CI testing.

tslint version: 5.16.0 error message

[SyntaxError: Unexpected token {]
KoteiIto commented 5 years ago

I updated aws-sdk version on v2.5.1. Please use this version.

dhmachado commented 5 years ago

Great @KoteiIto, thanks !!