search

Kotlin-Polytech / KotlinAsFirst

Задачи для онлайн-курса "Котлин как первый язык программирования"
Creative Commons Attribution Share Alike 4.0 International
74 stars 115 forks source link

Test for Lesson 1, Task 1 is not comparable with condition of this Task #107

Closed fembiba closed 3 years ago

fembiba commented 3 years ago

Condition of Task mean, values must be more than 100, but in Test we tested with 100 value.

I suggest fix condition of Task to more than or equals 100

https://github.com/Kotlin-Polytech/KotlinAsFirst/blob/35925dfc5c7bf1e566102d67afb546a8e1a37627/src/lesson1/task1/Simple.kt#L98

https://github.com/Kotlin-Polytech/KotlinAsFirst/blob/35925dfc5c7bf1e566102d67afb546a8e1a37627/test/lesson1/task1/Tests.kt#L83

ice-phoenix commented 3 years ago

Hi mate, thanks for noticing this bug in the description! Out of curiosity, why did you decide to use the unconventional order of "равно или больше" instead of a more widely used "больше или равно"?

fembiba commented 3 years ago

Hi too! In order to focus on "равно" word. But this is a bad idea. I guess.

fembiba commented 3 years ago

Oki. I'm refactored.

ice-phoenix commented 3 years ago

Could I ask you to squash the commits in your branch, so that it contains a single commit with the needed changes?

fembiba commented 3 years ago

Could I ask you to squash the commits in your branch, so that it contains a single commit with the needed changes?

Oks. I did it