search

Kotlin / KEEP

Kotlin Evolution and Enhancement Process
Apache License 2.0
3.29k stars 357 forks source link

Merge Data objects to master #351

Closed nikitabobko closed 4 months ago

nikitabobko commented 1 year ago

@elizarov @zarechenskiy are you ok with "Rebase and merge"? It's an existing branch. The last contribution to the branch was reviewed https://github.com/Kotlin/KEEP/pull/334

I want to merge into master

nikitabobko commented 1 year ago

But let's firstly merge "data objects use-cases section" into data-objects branch https://github.com/Kotlin/KEEP/pull/352/files

qwwdfsad commented 1 year ago

[Just passing by, don't mind me]

IMO it should be squashed -- there is no value in re-iterative commits, "invalid markdown syntax" etc. in the history; these are purely the technicality of the development process

zarechenskiy commented 1 year ago

@elizarov @zarechenskiy are you ok with "Rebase and merge"? It's an existing branch. The last contribution to the branch was reviewed #334

I want to merge into master

Yes, but I tend to agree with @qwwdfsad that id' be nicer to squash these commits.

nikitabobko commented 4 months ago

Squashed and merged. All commit contributors are mentioned in Co-authored-by