Kotlin / binary-compatibility-validator

Public API management tool
Apache License 2.0
800 stars 59 forks source link

Correctly handle disappeared native/web targets #236

Closed fzhinkin closed 3 months ago

fzhinkin commented 4 months ago

To handle cases when a dump containing declarations for Apple targets is validated on hosts not supporting these targets, BCV filters out a golden dump committed to the repo.

Unfortunately, the filtration logic was invalid. Instead of filtering out targets known to be unsupported, the corresponding task was filtering out everything except supported targets. If a target was removed from the config, it could no longer make it to a set of supported/enabled targets, and the aforementioned task would filter it out.

Fix changes the filtration logic only to remove targets that were defined in a project but are known to be unsupported.

Fixes #234