Open Jolanrensen opened 6 months ago
https://github.com/Kotlin/dataframe/issues/352 probably same problem
As mentioned here https://github.com/Kotlin/dataframe/issues/543, some functions like median(ints)
might result in an unexpectedly rounded Int
in return. It might be better to let all functions return Double
and then handle BigInteger
/ BigDecimal
separately for now, as they're java-specific for now.
It looks like an umbrella ticket and should be split to a smaller task
This happens because the
Iterable<Number>.std()
function acceptsNumber
but doesn't convert them toDouble
(likemean()
does).There are a couple more missing actually:
cumSum
Byte
,Short
DataColumn
overloads but notIterable
/Sequence
mean
Sequence<Double | Float>
but not for otherNumber
typesmedian
Float
,Byte
,Short
,Number
(it only works onComparable
)Sequence
overloadsskipNA
(if applicable)min
andmax
Iterable<T>.min
andmax
are not used and can be removed. Stdlib functions for Comparable sequences and iterables are used instead.Number
(it only works onComparable
)std
Number
Short
andByte
are cast toInt
which works but is a bit iffyNumber
,Short
,Byte
varianceAndMean
std(ddof: Int)
function without docs of what ddof even means, as well ascount
. Could have a better name. Also can produce nulls?? this screams for documentation.Short
,Byte
,Number
, and nullable overloadssum
TODO
s where types are amissFloat
(!),Short
,Byte
,Number
in variousIterable
overloads.All are also missing
BigInteger
as we're supportingBigDecimal
too.