search

Kotlin / dataframe

Structured data processing in Kotlin
https://kotlin.github.io/dataframe/overview.html
Apache License 2.0
821 stars 58 forks source link

Fix for #573: Change serialization format for rendering in IntelliJ IDEA #574

Closed ermolenkodev closed 7 months ago

ermolenkodev commented 8 months ago

Fixes https://github.com/Kotlin/dataframe/issues/573

koperagen commented 8 months ago

Can i ask you to move internal and private functions from this file to new writeJson.kt / readJson.kt files under impl.io package? This file became too big to navigate :c

koperagen commented 8 months ago

You changed handling of value and array columns. Can you tell me more about changes? This part of serialization was not tested by unit tests thoroughly before. I worry if things might break (no test coverage) image

ermolenkodev commented 7 months ago

Can i ask you to move internal and private functions from this file to new writeJson.kt / readJson.kt files under impl.io package? This file became too big to navigate :c

done

ermolenkodev commented 7 months ago

You changed handling of value and array columns. Can you tell me more about changes? This part of serialization was not tested by unit tests thoroughly before. I worry if things might break (no test coverage) image

I have extracted the code that filters autogenerated values and array columns into functions to be reused in new methods. I have double-checked the logic, and it seems it hasn't been altered. However, I can't guarantee this without running tests. If this is critical, we should add tests and merge them before proceeding with this pull request.