search

Kotlin / dataframe

Structured data processing in Kotlin
https://kotlin.github.io/dataframe/overview.html
Apache License 2.0
768 stars 48 forks source link

Fix for mac-os permissions pre-commit #616

Closed Jolanrensen closed 3 months ago

Jolanrensen commented 4 months ago

Fixes https://github.com/Kotlin/dataframe/issues/612

Jolanrensen commented 4 months ago

@devcrocod Could you check the latest version of this branch on your mac?

Jolanrensen commented 3 months ago

I enabled the workaround for Linux too since we noticed the same problem happening there sometimes too. Plus, it doesn't hurt to run it if the problem isn't there.

koperagen commented 3 months ago

I can confirm that chmod does its job, but i don't like how that hook works now :c I tried to commit just one file, but it added all other uncommited files and delay was quite evident too

Jolanrensen commented 3 months ago

I can confirm that chmod does its job, but i don't like how that hook works now :c I tried to commit just one file, but it added all other uncommited files and delay was quite evident too

I agree. It's mostly there so newly generated files are added to the git index automatically, because people forget. But it should mirror the commits to src only. That said, that's another issue :)