Kotlin / dataframe

Structured data processing in Kotlin
https://kotlin.github.io/dataframe/overview.html
Apache License 2.0
763 stars 48 forks source link

Missing tests for `unfold` #677

Open Jolanrensen opened 2 months ago

Jolanrensen commented 2 months ago

As the title says. Unfold is a sort-of in-dataframe .toDataFrame() conversion (https://kotlin.github.io/dataframe/unfold.html), but this behavior isn't tested anywhere, nor do we check it's consistent with our Iterable<>.toDataFrame() overloads.

Related to unfold, we should probably rename AnyCol.isPrimitive() and KClass<*>.isPrimitive() to isValueType() or something, because "primitive" has a different meaning in the JVM world.

Jolanrensen commented 2 months ago

Related to https://github.com/Kotlin/dataframe/issues/177#issuecomment-1358968584 and https://github.com/Kotlin/dataframe/pull/197