search

Kotlin / dataframe

Structured data processing in Kotlin
https://kotlin.github.io/dataframe/overview.html
Apache License 2.0
813 stars 57 forks source link

Rename private properties with names matching library classes #737

Closed koperagen closed 3 months ago

koperagen commented 3 months ago

Sometimes these private properties appear in import quick fix image

Jolanrensen commented 3 months ago

maybe they could be renamed to _dataFrame even? That would further hint that they're not supposed to appear and maybe make them appear even further down the list

koperagen commented 3 months ago

I wouldn't go as far because it seems like a bug on IDEA side to suggest private properties anyway, and lowercase properties do not appear when DataFrame is typed

Jolanrensen commented 3 months ago

I wouldn't go as far because it seems like a bug on IDEA side to suggest private properties anyway, and lowercase properties do not appear when DataFrame is typed

true, but I think a lot of users will create variables named df or dataFrame, which will now mix with these private ones.

koperagen commented 3 months ago

I wouldn't go as far because it seems like a bug on IDEA side to suggest private properties anyway, and lowercase properties do not appear when DataFrame is typed

true, but I think a lot of users will create variables named df or dataFrame, which will now mix with these private ones.

These private properties seem to only leak to "import quick fix", so shouldn't be a problem for variables