Open AndreiKingsley opened 1 month ago
First of all, thanks! Good idea, certainly in combination with Kandy. I'll think about the proposal some more but I've already got a quick comment in terms of the proposed API:
For all formats, DataFrame follows the structure:
DataFrame.read`SOME TYPE`(input): DataFrame<*>
this is because DataFrame.read(input)
should be able to guess any of the supported types, so, also for consistency, this should be adhered to.
I think it's fine to make an exception for the return type, so you could return something like DataFrame<GeoDataRow>
. Making a subtype of DataFrame
will likely cause many bugs due to the way the library is designed, but with extension functions I think many ideas you have will be possible with a simple typealias.
This would adjust the proposed API to:
typealias GeoDataFrame = DataFrame<GeoDataRow>
fun DataFrame.readGeoJson(input): GeoDataFrame
fun DataFrame.readShapeFile(input): GeoDataFrame
and if you use the non-specific read function:
DataFrame.read(geoJsonInput).cast<GeoDataRow>()
// or
DataFrame.read(geoJsonInput).asGeoDataFrame()
Lets-plot geo examples:
Add a module for working with geodata in DataFrame.
Essentially all geoformats store a dataframe of geometric objects (that is, regular objects with data, but also with their own geometry, which is defined in one way or another). Thus, it is natural to read geodata into a DataFrame - simple, linear (possibly with nested columns) with geometry column. We also need to do some transformations of this data/make calculations on it (see examples below). Working name -
GeoDataFrame
Formats
To starts, let's support the two most popular data formats (rest, if necessary, will be easy to support):
GeoJSON is more prioritized because it is more modern, easier to share (unlike shpafile it is textual and also comes in one file). Nevertheless shapefile is definitely worth supporting as it is widely used (and if we use geotool, it will cost nothing).
Possible API’s:
Reading result:
Reading following geojson should leads to DataFrame with the following schema:
Implementation: Reading most popular types (including geojson and shapefile) is supported in geotools. The internal representation in geotools is similar to a DataFrame, so converting it to a GeoDataFrame should not be difficult.
Geometry
Further, to work with geometry we need the type -
Geometry
. And here it seems the only correct solution is to take the JTS library. This is a standard solution not only in Java, but even in C++ and Python. Moreover, it is used in GeoTools, so if we use geotools for data read implementation, we don't need to do any additional conversions.Processing
Example of possible actions with
GeoDataFrame
: