Fix DGPv2 migration helpers

Kotlin / dokka

API documentation engine for Kotlin

https://kotl.in/dokka

Apache License 2.0

3.45k stars 410 forks source link

Fix DGPv2 migration helpers #3804

Closed adam-enko closed 2 months ago

adam-enko commented 2 months ago

Adjust the DGPv2 migration helpers to better support migration.

Create dokka${Format}${Subtype}Plugin (e.g. dokkaHtmlMultiModulePlugin) Configurations.
Now that DGP has HTML and Javadoc plugins, adjust the deprecated dokkaRuntime Configuration to redirect to the 'base' dokkaGeneratorRuntime Configuration instead of the HTML-specific dokkaHtmlGeneratorRuntime.

adam-enko commented 2 months ago

LGTM

Note: KotlinDslAccessorsTest "dumps" are not really helpful here :(

Well, their main purpose is to ensure that we don't accidentally break users' buildscripts by changing the generated accessors. This PR is intentionally modifying the accessors, so we expect changes. But yes, the the actual changes are difficult to discern.