Open whyoleg opened 3 weeks ago
DGPv2 uses kotlinx.serialization for encoding the parameters for the HTML and Versioning Dokka plugins, but yes, I agree it could be removed. It'd help keep the buildscripts cleaner.
I've extracted removing compiler plugin into separate PR (https://github.com/Kotlin/dokka/pull/3899).
Also, @adam-enko, it would be nice if you could take a look on the reason of test failures in this PR. E.g here is the build scan from this GA build. Tests failed for dokka-gradle-plugin
only.
Not urgent, but would be nice to know the reason
I've extracted removing compiler plugin into separate PR (#3899). Also, @adam-enko, it would be nice if you could take a look on the reason of test failures in this PR. E.g here is the build scan from this GA build. Tests failed for
dokka-gradle-plugin
only. Not urgent, but would be nice to know the reason
Some tests are failing because there's extraneous logging in build scripts
The test uses a custom Dokka plugin to cause Dokka to log info/warn/error logs, but it's compiled with an incompatible Kotlin version (the embedded Kotlin version).
Some tests are failing because AGP
Caused by: org.gradle.api.InvalidUserCodeException: Kotlin Gradle Plugin <-> Android Gradle Plugin compatibility issue:
The applied Android Gradle Plugin version (7.1.3) is lower than the minimum supported 7.3.1.
compilation is failing with:
Probably there is some issue with kotlinx.serialization compiler plugin usage when using
kotlin.compiler.runViaBuildToolsApi
. KGP version = 2.1.0-RC-330 Kotlin compiler version used to compile code = 2.0.20 I've tried to set all different versions of kotlinx.serialization plugins, but none of them work.Not sure where the issue comes from, but probably the easiest way will be to drop
kotlinx.serialization
usage from DGPv2 so that there will be less moving parts :) It's possible to replace it:kotlinx.serialization
usage viaJsonObject
kotlinx.serialization
can be fully dropped as it's used only for single class which could be easily replaced with just a txt file with 4 lines :)Note: last commit adds a workaround: https://github.com/Kotlin/dokka/pull/3898/commits/d43e162bdbe4bfd05338b679ada91b28385604c1
with applied workaround, there are several failed DGPv2 functional tests