Open vlsi opened 4 years ago
Let's discuss - why?
Does
get() = definedExternally
set(value) = definedExternally
add anything significant?
It looks like it adds nothing, and it makes the code harder to follow. That is why I suggest to remove it.
I agree it may improve a bit the readability when we have to read the declaration files. However, since this code is generated, I don't believe this is really important. The rest of the ecosystem should be made so that we don't have to read generated files.
So I guess it may be worth making this change, but only after many other issues with high priority are solved.
Could Dukat please strip
get() = definedExternally set(value) = definedExternally
from the generated code?Sample from
@octokit/types 5.4.0
:Generated Kotlin code: