search

Kotlin / kandy

Kotlin plotting library.
https://kotlin.github.io/kandy/
Apache License 2.0
603 stars 16 forks source link

Add `plotInset` parameter to style #406

Open AndreiKingsley opened 3 months ago

AndreiKingsley commented 3 months ago

https://nbviewer.org/github/JetBrains/lets-plot-kotlin/blob/master/docs/examples/jupyter-notebooks/f-4.7.1/theme_plot_inset.ipynb

lucas-watkins commented 2 months ago

Hello, if this issue is still available may I please try to solve it?

AndreiKingsley commented 2 months ago

Yes, you are welcome.

You need to add the inset property to the PlotCanvas custom style configuration. First you need to research its behavior in Lets-Plot and design API for it.

lucas-watkins commented 2 months ago

I have implemented an API that is very similar to the existing one that handles margins. However, I read in CONTRIBUTING.md that all new APIs must come with documentation. Is it appropriate to add documentation in the docs folder or the examples folder in this case?

AndreiKingsley commented 2 months ago

Custom style API is still unstable, we haven't done documentation and tests yet, so you can add it without them for now.