search

Kotlin / kotlin-by-example

The sources of Kotlin by Example.
https://play.kotlinlang.org/byExample/overview
MIT License
460 stars 897 forks source link

Update 01_When.md #189

Closed D3nn7 closed 2 years ago

D3nn7 commented 2 years ago

use number instead on name for "1".

SebastianAigner commented 2 years ago

I'm afarid the quotation marks make this PR more confusing than the original – it makes it harder to discern whether a string or an integer is meant. If you'd like, you could update this to put the Strings in quotes ("Hello") and the numbers without quotes (1) – that should be an improvement over the current state :)

D3nn7 commented 2 years ago

Thanks for the idea, you're right. I have update it. Please review again.

SebastianAigner commented 2 years ago

Excellent, this looks great! Thanks for your contribution – merging! 🎉