Make sure frontend plugin withs with new kotlin-multiplatform plugin

Kotlin / kotlin-frontend-plugin

Gradle Kotlin (http://kotlinlang.org) plugin for frontend development

Apache License 2.0

561 stars 69 forks source link

Make sure frontend plugin withs with new kotlin-multiplatform plugin #118

Closed felipecsl closed 5 years ago

felipecsl commented 5 years ago

Fixes #117

wem commented 5 years ago

Does it work for you without limitations and workarounds? For me the JS dependencies are not found because in the Task org.jetbrains.kotlin.gradle.frontend.npm.UnpackGradleDependenciesTask the compile configuration will be used to lookup dependencies. But in the case of MPP, the configurations has changed. As a workaround the JS dependencies must be defined as well in a top-level dependency closure.

snrostov commented 5 years ago

@felipecsl Sorry, for long delay. As @wem noted, other things including classpath configuration should be fixed. Also some smoke test would be good. Please see #126.

Anyway, thanks for contribution!