search

Kotlin / kotlin-fullstack-sample

Kotlin Full-stack Application Example
https://kotlinlang.org
Apache License 2.0
1.22k stars 167 forks source link

Update Gradle wrapper to Gradle 4.1 #21

Closed eriwen closed 6 years ago

eriwen commented 6 years ago

Gradle 4.1 is far faster than 3.1, and will allow us to take advantage of Gradle's Kotlin DSL later, among other things.

Go Kotlin or go home ;)

Testing Done

Successfully ran backend and frontend and tested all main routes through the browser. Are there other tests I ought to run for future contributions?

cy6erGn0m commented 6 years ago

Hm, I used to think that it doesn't work with 4.x. On which OS have you tried this?

eriwen commented 6 years ago

@cy6erGn0m I tested it with macOS. Can you recall any specific failure you were getting on Gradle 4.x?

cy6erGn0m commented 6 years ago

I was experiencing native incompatibility caused by ruby grapefruit process launcher. Perhaps I have to try it again

cy6erGn0m commented 6 years ago

@eriwen Have tried it and it works well. However it dosn't with 4.2.x

cy6erGn0m commented 6 years ago

Thanks!

eriwen commented 6 years ago

I was about to investigate, but it seems like you got it working with 4.2 :)