search

Kotlin / kotlin-jupyter

Kotlin kernel for Jupyter/IPython
Apache License 2.0
1.1k stars 105 forks source link

Every execution request increments `execution_count`, even if `store_history=False` #326

Closed strangepleasures closed 2 years ago

strangepleasures commented 2 years ago

According to Jupyter documentation, execution_count should be incremented only when store_history=True: "The kernel should have a single, monotonically increasing counter of all execution requests that are made with store_history=True. This counter is used to populate the In[n] and Out[n] prompts. The value of this counter will be returned as the execution_count field of all execute_reply and execute_input messages.".

However, currently even requests with store_history=False increment the counter.

ileasile commented 2 years ago

Yes, we don't take silent and store_history into consideration for now