Closed ileasile closed 1 year ago
I'm concerned about names too: it's not clear what gradle
means, it sounds like we configure Gradle, not kernel. But I can't come up with a better name for this DSL entry point
Maven resolver is used underhood, yes.
I'm concerned about names too: it's not clear what
gradle
means, it sounds like we configure Gradle, not kernel. But I can't come up with a better name for this DSL entry point Maven resolver is used underhood, yes.
maybe something like requires
? It does not matter how it is called since you copy only what is inside.
gradle
- clear what you should write inside but doesn't explain the purposegradleLike[Conf]
- better, but verboserequires
- good borrowing from JS modules, but there is require
in Kotlin, and may be misleadingconfig
, configure
, provide
- not bad, but too genericbuild
- looks like a compromise variantdependencyResolutionManagement
- name of block in settings.gradle[.kts]
that is actually responsible for dependency managementLet's choose something please
@ileasile I think it is better to discuss in slack. Maybe a vote.
I do not think that the outer scope should match how it looks in Gradle because people do not copy the whole block, they copy its contents. Also dependencyResolutionManagement
is not used in project config, only in settings
.
What about dependsOn{ }
?
Final version of API:
USE {
repositories {
mavenCentral()
}
dependencies {
implementation("io.github.config4k:config4k:0.4.2")
}
}
Or in integration:
internal class Integration : JupyterIntegration() {
override fun Builder.onLoaded() {
repositories {
mavenCentral()
}
dependencies {
implementation("io.github.config4k:config4k:0.4.2")
}
}
}
Fix #367