search

Kotlin / kotlinx-atomicfu

The idiomatic way to use atomic operations in Kotlin
Other
925 stars 59 forks source link

Fix wrong test setup #470

Closed Tapchicoma closed 2 months ago

Tapchicoma commented 2 months ago

Test project was applying Kotlin KMP plugin in subprojects, but not in the root 'build.gradle.kts' which is wrong from KMP point of view as it introduces Gradle classpath isolation problem.

Tapchicoma commented 2 months ago

Fixes failure in MR into 2.0.21 branch for https://youtrack.jetbrains.com/issue/KT-70700

woainikk commented 2 months ago

can we merge it directly to develop branch?

mvicsokolova commented 2 months ago

Yes, we should first merge it into develop and then rebase kotlin-community

mvicsokolova commented 2 months ago

@Tapchicoma could you please rebase this commit onto develop? Or should I better do this?

Tapchicoma commented 2 months ago

@mvicsokolova I am not sure how changes from kotlin-community/dev should land in develop branch. If possible - could you cherry-pick it after the merge?

Tapchicoma commented 2 months ago

Actually I've just rebased against develop