search

Kotlin / kotlinx-benchmark

Kotlin multiplatform benchmarking toolkit
Apache License 2.0
499 stars 40 forks source link

[wasm] fix name of wasm target onto wasmJs #129

Closed ilgonmic closed 1 year ago

qurbonzoda commented 1 year ago

Could you please clarify why this change is happening?

igoriakovlev commented 1 year ago

Could you please clarify why this change is happening?

@qurbonzoda We are going to add second wasm backend target, so we have renamed corresponding gradle dsl. This changes here is unnecessary to do now (as far as I understand old DSL is still availible with deprecation) but, it is always better to be at cutting edge of technologies. :)

BTW, @ilgonmic, Do we need to apply such changes to all libraries?

ilgonmic commented 1 year ago

Do we need to apply such changes to all libraries?

Now only benchmark is failing CI, so looks like other libraries can be migrated later