search

Kotlin / kotlinx-benchmark

Kotlin multiplatform benchmarking toolkit
Apache License 2.0
499 stars 40 forks source link

Gradle Kotlin DSL accessor generated for the benchmark tasks are invalid. #254

Closed sureshg closed 1 week ago

sureshg commented 1 month ago

I'm not sure if this is an issue with the Gradle Kotlin DSL or the Kotlinx benchmark plugin. Please feel free to close this issue if you believe it's unrelated to the plugin. After updating to version 4.12, the Gradle Kotlin DSL accessor generated is incorrect and is throwing the following error.

internal
fun <T : ModuleDependency> DependencyHandler.`benchmarkGenerator.resolver`(
    dependency: T,
    dependencyConfiguration: T.() -> Unit
): T = add("benchmarkGenerator.resolver", dependency, dependencyConfiguration)

> Task :build-logic:compileKotlin FAILED

e: file:/xx/gradle/build-logic/build/generated-sources/kotlin-dsl-accessors/kotlin/gradle/kotlin/dsl/accessors/_6843e0e67e615bf28f2b60b0ca847c39/Accessors1rq9itv9g97iytjv9b0ah90w.kt:65:87 Name contains illegal characters: .
e: file:/xxx/gradle/build-logic/build/generated-sources/kotlin-dsl-accessors/kotlin/gradle/kotlin/dsl/accessors/_6843e0e67e615bf28f2b60b0ca847c39/BenchmarkGenerator.resolverConfigurationAccessors.kt:70:23 Name contains illegal characters: .
e: file://xxxx/gradle/build-logic/build/generated-sources/kotlin-dsl-accessors/kotlin/gradle/kotlin/dsl/accessors/_6843e0e67e615bf28f2b60b0ca847c39/BenchmarkGenerator.resolverConfigurationAccessors.kt:83:23 Name contains illegal characters:
sureshg commented 1 week ago

Any workaround for this issue? I am still having the same issue after updating to 4.12

sureshg commented 1 week ago

nm..seems like a Gradle issue - https://github.com/gradle/gradle/issues/30340