Kotlin / kotlinx-kover

Apache License 2.0
1.28k stars 48 forks source link

Release candidate version in readme doesn't work #116

Closed lenguyenthanh closed 2 years ago

lenguyenthanh commented 2 years ago

When I follow the setup in readme:

plugins {
     id("org.jetbrains.kotlinx.kover") version "0.5.0-RC"
}

Gradle tasks always failed. After I downgrade kover to 0.4.0, everything is working fine.

I think the problem is we need some to add some maven repository in order to use release candidate versions.

shanshin commented 2 years ago

Hi, may you clarify with what error the build crashes? You may copy the error from Gradle logs

lenguyenthanh commented 2 years ago

When I run with ./gradlew check --debug it will run forever, here is when it got stucked:

2022-01-11T12:40:41.283+0100 [DEBUG] [org.gradle.internal.operations.DefaultBuildOperationRunner] Build operation 'Apply plugin org.gradle.application to project ':app'' completed
2022-01-11T12:40:45.769+0100 [LIFECYCLE] [org.gradle.cache.internal.DefaultFileLockManager] 
2022-01-11T12:40:45.769+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Waiting to acquire shared lock on daemon addresses registry.
2022-01-11T12:40:45.769+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
2022-01-11T12:40:45.769+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Releasing lock on daemon addresses registry.
2022-01-11T12:40:45.769+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Waiting to acquire shared lock on daemon addresses registry.
2022-01-11T12:40:45.769+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
2022-01-11T12:40:45.770+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Releasing lock on daemon addresses registry.
2022-01-11T12:40:55.765+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Waiting to acquire shared lock on daemon addresses registry.
2022-01-11T12:40:55.765+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
2022-01-11T12:40:55.765+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Releasing lock on daemon addresses registry.
2022-01-11T12:40:55.765+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Waiting to acquire shared lock on daemon addresses registry.
2022-01-11T12:40:55.765+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
2022-01-11T12:40:55.765+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Releasing lock on daemon addresses registry.
2022-01-11T12:41:05.766+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Waiting to acquire shared lock on daemon addresses registry.
2022-01-11T12:41:05.766+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
2022-01-11T12:41:05.766+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Releasing lock on daemon addresses registry.
2022-01-11T12:41:05.767+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Waiting to acquire shared lock on daemon addresses registry.
2022-01-11T12:41:05.767+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
2022-01-11T12:41:05.767+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Releasing lock on daemon addresses registry.
shanshin commented 2 years ago

What logs will there be if you run the build without using previously started daemons? eg /gradlew check --debug --no-daemon

lenguyenthanh commented 2 years ago

I have the same result with ./gradlew check --debug --no-daemon Maybe I need to clarify my dependencies: I'm using gradle wrapper 7.3.3 and Kotlin 1.6.10. And my maven repositories:

repositories {
  mavenCentral()
  maven { url = uri("https://jitpack.io") }
  maven { url = uri("https://oss.sonatype.org/content/repositories/snapshots")}
}
shanshin commented 2 years ago

Can you provide a small reproducer project?

lenguyenthanh commented 2 years ago

yes, I can. I will create sometime today or tomorrow.

lenguyenthanh commented 2 years ago

I don't have time today, so I'll create a sample project over the weekend or next week!

lenguyenthanh commented 2 years ago

Hey, I have a sample here: https://github.com/lenguyenthanh/sparrow/pull/4.

shanshin commented 2 years ago

Thanks for the reproducer! Try to apply the plugin in the root project, instead of the app, this should solve the problems.

lenguyenthanh commented 2 years ago

oh, thanks for the tip. Is this something kover will fixed or is it caused by something else? If the latter should we add something to Readme? I can create a PR.

shanshin commented 2 years ago

We will fix this in the plugin code in the next release.

shanshin commented 2 years ago

Fixed in 0.5.0