Kotlin / kotlinx-rpc

Add asynchronous RPC services to your multiplatform applications.
https://kotlin.github.io/kotlinx-rpc/
Apache License 2.0
749 stars 17 forks source link

krpc-ktor-server to support Multiplatform #209

Closed tristancaron closed 1 week ago

tristancaron commented 1 month ago

Looking at the content of this module, it does seem that it could be moved under commonMain. Its dependencies are supporting multiplatform.

https://github.com/Kotlin/kotlinx-rpc/blob/main/krpc/krpc-ktor/krpc-ktor-server/build.gradle.kts

Mr3zee commented 1 month ago

Hi! The server module uses JVM reflection to invoke service methods, so the update is not straightforward. But we plan to do it eventually, yes

TristanCaronUnity commented 1 month ago

Ah missed that one. Thanks for the update.

Zymus commented 1 month ago

Hi! The server module uses JVM reflection to invoke service methods, so the update is not straightforward. But we plan to do it eventually, yes

Thanks for the JVM tip. I was struggling getting a MP with mingw setup, and hadn't targeted jvm in my project yet. Adding jvm and removing mingw allowed me to build.

xeodon commented 2 weeks ago

If you look at the source code, there is still weak support for code generation in the project. Therefore, hacks at the JVM level.

Mr3zee commented 1 week ago

It's actually a duplicate for #83