Kotlin / kotlinx.collections.immutable

Immutable persistent collections for Kotlin
Apache License 2.0
1.16k stars 59 forks source link

(Re)publish the library on maven central #96

Closed ilya-g closed 3 years ago

ilya-g commented 3 years ago

Considering the news that jcenter is going to sunset soon, we need to setup publishing to maven central repository.

Jose-Parente commented 3 years ago

The latest canary of Android Studio has now removed jcenter() in favor of mavenCentral()

yahyatinani commented 3 years ago

+1

WebTiger89 commented 3 years ago

+1

laurenyew-nytimes commented 3 years ago

+1

ykws commented 3 years ago

https://github.com/Kotlin/kotlinx.html/issues/173#issuecomment-800504909

Is it recommended to use the following snippet similar to the linked issue?

jcenter {
    content {
        includeModule("org.jetbrains.kotlinx", "kotlinx-collections-immutable-jvm")
    }
}
saurabhraj042 commented 3 years ago

facing same issue

jeremyrempel commented 3 years ago

Kotlin/kotlinx.html#173 (comment)

Is it recommended to use the following snippet similar to the linked issue?

jcenter {
    content {
        includeModule("org.jetbrains.kotlinx", "kotlinx-collections-immutable-jvm")
    }
}

Yes. The snippet just means the only dependency that can be obtained from jcenter is the specified one.

boswelja commented 3 years ago

Seems to be live now https://mvnrepository.com/artifact/org.jetbrains.kotlinx/kotlinx-collections-immutable-jvm/0.3.3 I've removed jcenter from my project and I haven't run into any issues yet Edit: Seems like my local cache was filling in, even though I cleared caches and restarted. The artifact isn't found though strangely I can find it at the link above.

maxcruz commented 3 years ago

Unfortunately, it's still failing when you compile without jcenter():

Execution failed for task ':app:checkDebugAarMetadata'.
> Could not resolve all files for configuration ':app:debugRuntimeClasspath'.
   > Could not find org.jetbrains.kotlinx:kotlinx-collections-immutable-jvm:0.3.3.
     Searched in the following locations:
       - https://dl.google.com/dl/android/maven2/org/jetbrains/kotlinx/kotlinx-collections-immutable-jvm/0.3.3/kotlinx-collections-immutable-jvm-0.3.3.pom
       - https://repo.maven.apache.org/maven2/org/jetbrains/kotlinx/kotlinx-collections-immutable-jvm/0.3.3/kotlinx-collections-immutable-jvm-0.3.3.pom
     Required by:
         project :app > androidx.compose.ui:ui:1.0.0-beta02 > androidx.compose.runtime:runtime:1.0.0-beta02

Possible solution:
 - Declare repository providing the artifact, see the documentation at https://docs.gradle.org/current/userguide/declaring_repositories.html
qurbonzoda commented 3 years ago

The new version of the library, 0.3.4, is published to the Maven Central repository. Thank you for the patience! Readme will be updated soon.

tajchert commented 3 years ago

I'm also facing the same issue, can you also republish 0.3.3 version?

Current version of androidx.compose.runtime:runtime:1.0.0-beta03 on Android uses 0.3.3 version:

Execution failed for task ':xxxx'.
> Could not resolve all files for configuration ':xxxx:debugAndroidTestRuntimeClasspath'.
   > Could not resolve org.jetbrains.kotlinx:kotlinx-collections-immutable-jvm:0.3.3.
     Required by:
         project :xxx > androidx.compose.runtime:runtime:1.0.0-beta03
      > Could not resolve org.jetbrains.kotlinx:kotlinx-collections-immutable-jvm:0.3.3.
maxcruz commented 3 years ago

I'm also facing the same issue, can you also republish 0.3.3 version?

Current version of androidx.compose.runtime:runtime:1.0.0-beta03 on Android uses 0.3.3 version:

Execution failed for task ':xxxx'.
> Could not resolve all files for configuration ':xxxx:debugAndroidTestRuntimeClasspath'.
   > Could not resolve org.jetbrains.kotlinx:kotlinx-collections-immutable-jvm:0.3.3.
     Required by:
         project :xxx > androidx.compose.runtime:runtime:1.0.0-beta03
      > Could not resolve org.jetbrains.kotlinx:kotlinx-collections-immutable-jvm:0.3.3.

I guess this issue is going to be solved when compose-ui moves to 1.0.0-beta04 As a workaround, you could add version 0.3.4 explicitly to force the dependency resolution.

implementation "org.jetbrains.kotlinx:kotlinx-collections-immutable-jvm:0.3.4"

qurbonzoda commented 3 years ago

As of now we have no plans to republish the old versions to Maven Central. We have discussed the issue with compose-ui folks, they will shade the dependency or will move to 0.3.4.