Kotlin / kotlinx.coroutines

Library support for Kotlin coroutines
Apache License 2.0
13.06k stars 1.85k forks source link

`kotlinx.coroutines.debug`'s `module-info.java` is incorrect preventing any project using JPMS to use debug probes #4124

Open ArchangelX360 opened 6 months ago

ArchangelX360 commented 6 months ago

Any usage of the kotlinx.coroutines.debug package, for example import kotlinx.coroutines.debug.DebugProbes results in:

[JAVA_MODULE_DOES_NOT_EXPORT_PACKAGE] Symbol is declared in module 'kotlinx.coroutines.debug' which does not export package 'kotlinx.coroutines.debug'

The split package between kotlinx.coroutines.core and kotlinx.coroutines.debug of package kotlinx.coroutines.debug must be solved and cannot be hacked around by commenting its exports statement in kotlinx.coroutines.debug's module-info.java 😒.


To continue the investigation, using custom module loading code, we merged kotlin.stdlib, kotlinx.coroutines.core and kotlinx.coroutines.debug modules at runtime:

That provided us with a few more information about what is wrong with the current module-info.java:

  1. some statements are missing (probably coming from the shadowing of bytebuddy):

    requires com.sun.jna;
    exports kotlinx.coroutines.repackaged.net.bytebuddy.agent to com.sun.jna;
  2. these redundant (bytebuddy being shadowed in the same module) requires crashes at runtime:

    requires net.bytebuddy.agent;
    requires net.bytebuddy;
  3. when used in production, the current declaration and structure of kotlinx-coroutines-debug jar forces users to bring in jars to their runtime module path to fulfill:

    requires org.junit.jupiter.api;
    requires org.junit.platform.commons;

    JUnit is not something one would want in production runtime module path πŸ˜…...


I did not find any suitable workaround to unblock ourselves. The only solution I see is to:

dovchinnikov commented 3 months ago

Related https://github.com/Kotlin/kotlinx.coroutines/issues/3633