search

Kotlin / kotlinx.html

Kotlin DSL for HTML
Apache License 2.0
1.61k stars 131 forks source link

Drop exception handler in for tag to reduce bytecode size #224

Closed e5l closed 1 year ago

languitar commented 1 year ago

Seems this change got into the 0.9.0 release without being somehow marked as a breaking change. For us, this has effectively broken error handling in a ktor project. Is this expected?

e5l commented 1 year ago

@languitar, yep, it is. Could you share the case of how exceptions were handled in your project?

languitar commented 1 year ago

What was broken was the integration with kotlinx html provided by ktor themselves. But it seems the vanished method is handled on main already: https://youtrack.jetbrains.com/issue/KTOR-6124/Not-compatible-with-kotlinx-html-0.9.1

Is it intended that breaking changes appear in this project without major version bumps?

e5l commented 1 year ago

Yep, it is before the stable 1.0.0release. Now we assume only patch releases safe