search

Kotlin / kotlinx.html

Kotlin DSL for HTML
Apache License 2.0
1.63k stars 133 forks source link

Exceptions are swallowed when StatusPages feature is installed #97

Closed marshallpierce closed 6 years ago

marshallpierce commented 6 years ago

Simple demo:

https://github.com/ktorio/ktor-samples/compare/master...marshallpierce:html-builder-status-pages-swallows-exceptions?expand=1

Expected behavior: I would expect the default to involve a 500 and the exception being logged somewhere, hopefully customizable via StatusPages. Rendering part of the DSL's execution with a 200 is highly misleading, to say the least.

marshallpierce commented 6 years ago

Oops, had too many kotlin github tabs open -- this should probably be in the ktor repo. Sorry for the noise!