search

Kotori316 / QuarryPlus

Advanced mining machines for Minecraft.
https://www.curseforge.com/minecraft/mc-mods/additional-enchanted-miner
GNU Lesser General Public License v3.0
59 stars 14 forks source link

Quarry entities not impacted by lighting #597

Open valknight opened 1 month ago

valknight commented 1 month ago

Describe the bug

Quarry "arm" and drill is unlit. With shaders on, this causes the arm to potentially render into the threshold for bloom, or otherwise very bright.

I've taken a cursory look through the source code, but unfortunately I'm unfamiliar with how Minecraft mod rendering works and it's past midnight 😅

To Reproduce

Steps to reproduce the behavior:

  1. Create quarry
  2. Power quarry

Expected: Quarry entity is impacted by lighting

Actual: Quarry entity is not impacted by lighting

Reproduction screenshot:

unlit_minearm

Note the arm is brighter in this example than the blocks around it

Versions

Other mods - [Fabric API](https://modrinth.com/mod/P7dR8mSH) [0.104.0+1.21.1] by FabricMC - [Resourceful Lib](https://modrinth.com/mod/G1hIVOrD) [3.0.10] by ThatGravyBoat, Epic_Oreo - [View Distance Fix](https://modrinth.com/mod/nxrXbh5K) [1.21.1-1.0.2] by Max Henkel - [AutoModpack bootstrap](https://modrinth.com/mod/k68glP2e) [1.0.0] by Skidam - [Handcrafted](https://modrinth.com/mod/pJmCFF0p) [4.0.2] by Alex Nijjar, Kekie6 - [Ears](https://ears.unascribed.com/) [1.4.6] by unascribed - [Ok Zoomer](https://modrinth.com/mod/aXf2OSFU) [9.3.0] by Ennui Langeweile, Up - [Entity Model Features](https://www.curseforge.com/minecraft/mc-mods/entity-model-features) [2.2.6] by Traben - [Cloth Config v15](https://minecraft.curseforge.com/projects/cloth-config) [15.0.130] by shedaniel - [Dynamic FPS](https://dapprgames.com/mods) [3.6.3] by juliand665, LostLuma - [OptiGUI](https://opekope2.dev/OptiGUI) [2.3.0-beta.2+1.21] by opekope2 - [Polytone](https://www.curseforge.com/minecraft/mc-mods/polytone) [1.21-2.4.15] by MehVahdJukaar - [FerriteCore](https://www.curseforge.com/minecraft/mc-mods/ferritecore-fabric) [7.0.0] by malte0811 - [Resourcify](https://modrinth.com/mod/resourcify) [1.4.2] by DeDiamondPro - [Styled Nicknames](https://pb4.eu) [1.6.0+1.21] by Patbox - Athena [4.0.1] by ThatGravyBoat - oωo [0.12.14+1.21] by glisco - [Reese's Sodium Options](https://github.com/FlashyReese/reeses-sodium-options) [1.8.0-beta.3+mc1.21.1] by FlashyReese - [Emoji Type](https://modrinth.com/mod/emoji-type) [2.2.7-1.21.1] by CyborgCabbage, Norbiros - [BCLib](https://modrinth.com/mod/bclib) [21.0.13] by Quiqueck, paulevs, Bulldog83 - [ImmediatelyFast](https://modrinth.com/mod/immediatelyfast) [1.2.21+1.21.1] by RK_01 - [EntityCulling](https://modrinth.com/mod/entityculling) [1.7.0] by tr7zw - [Better Combat](https://github.com/ZsoltMolnarrr/BetterCombat) [2.0.3+1.21.1] by Daedelus - RyoamicLights [0.2.11+mc1.21.1] by TexTrue, ThinkingStudio, LambdAurora - [Auto Warden Subtitles](https://modrinth.com/mod/auto-warden-subtitles) [2.0.4] by Thomas Smith - [Mod Menu](https://modrinth.com/mod/modmenu) [11.0.2] by Prospector, haykam821, TerraformersMC - [FastQuit](https://modrinth.com/mod/fastquit) [3.0.0+1.20.6] by KingContaria - [Continuity](https://modrinth.com/mod/continuity) [3.0.0-beta.5+1.21] by PepperCode1 - FabricSkyBoxes Interop [1.4.0+mc1.21-build.54] by FlashyReese - [Simple Copper Pipes](https://github.com/AViewFromTheTop/SimpleCopperPipesMC) [2.0] by Luna, Treetrain1 - [Chunks Fade In](https://github.com/kerudion/chunksfadein) [1.0.3-1.21] by Koteinik - [Bobby](https://modrinth.com/mod/bobby) [5.2.4+mc1.21] by johni0702 - [BetterF3](https://modrinth.com/mod/betterf3) [11.0.2] by cominixo, TreyRuffy - Spell Engine [1.1.1+1.21.1] by Daedelus - [Fabric Language Kotlin](https://minecraft.curseforge.com/projects/fabric-language-kotlin) [1.12.2+kotlin.2.0.20] by FabricMC - ThreadTweak [0.1.5+mc1.21.1] by getchoo, UltimateBoomer, fantahund - [ResolutionControl3](https://discord.gg/qJVwSK99G2) [${version}] by bgp, juliand665, UltimateBoomer, fantahund - [Puzzle](https://www.midnightdust.eu/) [2.0.0] by PuzzleMC, Motschen - Shield API [2.0.2+1.21.1] by TheRedBrain - [BetterGrassify](https://github.com/UltimatChamp/BetterGrassify) [1.1.1+fabric.1.21.1] by UltimatChamp, JayemCeekay - [Entity Sound Features](https://discord.gg/rURmwrzUcz) [0.4] by Traben - [Visuality](https://modrinth.com/mod/visuality) [0.7.7+1.21] by PinkGoosik - [Xaero's World Map](https://www.curseforge.com/minecraft/mc-mods/xaeros-world-map) [1.39.0] by xaero96 - [spark](https://spark.lucko.me/) [1.10.97] by Luck - [Noisium](https://modrinth.com/mod/noisium) [2.3.0+mc1.21-1.21.1] by Steveplays28 - [QuarryPlus](https://github.com/Kotori316) [21.1.103] by Kotori316 - [ObsidianUI](https://github.com/ThinkingStudios/ObsidianUI) [0.2.7+mc1.21] by TexTrue, ThinkingStudio, LambdAurora - [CIT Resewn](https://citresewn.shcm.io/) [1.2.0+1.21] by SHsuperCM - [ForgeLikeVersionChecker](https://github.com/Kotori316/automatic-potato) [2.4.0] by Kotori316 - [Sodium](https://github.com/CaffeineMC/sodium-fabric) [0.6.0-beta.2+mc1.21.1] by @jellysquid3 - [Model Gap Fix](https://www.curseforge.com/minecraft/mc-mods/model-gap-fix) [1.21-1.6] by MehVahdJukaar - [ModernFix](https://modrinth.com/mod/modernfix) [5.19.3+mc1.21.1] by embeddedt - [FrozenLib](https://www.modrinth.com/mod/FrozenLib) [1.8.6-mc1.21.1] by Treetrain1, Luna - [YetAnotherConfigLib](https://isxander.dev) [3.5.0+1.21-fabric] by isXander - [Cubes Without Borders](https://github.com/Kir-Antipov/cubes-without-borders) [2.1.1+1.21] by Kir_Antipov - [XaeroPlus](https://github.com/rfresh2/XaeroPlus) [2.24] by rfresh2 - Fix Keyboard on Linux [1.0.1] by ishland - [Main Menu Credits](https://isxander.dev) [1.2.0] by isXander - Paladins & Priests (RPG Series) [2.0.5+1.21.1] by Daedelus - Structure Pool API [1.1.3+1.21.1] by Daedelus - [Deeper and Darker](https://kyanitemods.dev/) [1.3.2.1] by Kyanite Mods - FabricSkyBoxes [0.7.4+mc1.21] by AMereBagatelle - [Just Enough Items](https://www.curseforge.com/minecraft/mc-mods/jei) [19.18.10.218] by mezz - [Right Click Harvest](https://github.com/JamCoreModding/right-click-harvest) [4.3.1+1.21] by Jamalam - [Animatica](https://github.com/FoundationGames/Animatica) [0.6.1+1.21] by FoundationGames - RangedWeaponAPI [2.0.4+1.21.1] by Daedelus - [Balm](https://mods.twelveiterations.com/) [21.0.19] by BlayTheNinth - [CC: Tweaked](https://tweaked.cc/) [1.113.1] by Daniel Ratcliffe, Aaron Mills, SquidDev - [Scalable Cat's Force Fabric](https://modrinth.com/mod/scalable-cats-force) [3.1.3] by Kotori316 - [WorldWeaver](https://github.com/quiqueck/WorldWeaver) [21.0.13] by Quiqueck - Runes [1.0.3+1.21.1] by Daedelus - Presence Footsteps [1.10.0+1.21] by Hurricaaane (Ha3), Sollace - [Point Blank](https://www.curseforge.com/minecraft/mc-mods/geckolib) [1.6.7] by vic4games, vic4gamesteam - [World Host](https://modrinth.com/mod/world-host) [0.4.14+1.21.1-fabric] by Gaming32 - [Sound Physics Remastered](https://www.curseforge.com/minecraft/mc-mods/sound-physics-remastered) [1.21.1-1.4.6] by Sonic Ether, vlad2305m, Max Henkel, Saint - [Chunky](https://www.curseforge.com/minecraft/mc-mods/chunky-pregenerator) [1.4.16] by pop4959 - Chipped [4.0.1] by Alex Nijjar, Grimbop, Kekie6, ThatGravyBoat - [AzureLib Armor](https://www.curseforge.com/minecraft/mc-mods/azurelib) [2.3.8] by AzureDoom, Gecko, Eliot, Chappie, DerToaster, Tslat, Bvanseg - [Energized Power](https://github.com/JDDev0/EnergizedPower) [1.21.1-2.12.3-fabric] by JDDev0 - [AdaptiveView](https://github.com/Tre5et/adaptiveview/releases) [2.3.0+1.21] by TreSet - [Celestria](https://www.midnightdust.eu/) [2.0.0] by Motschen, TeamMidnightDust - [Language Reload](https://modrinth.com/mod/language-reload) [1.6.1+1.21] by Jerozgen - [Waystones](https://mods.twelveiterations.com/mc/waystones) [21.1.4] by BlayTheNinth - Archers (RPG Series) [2.0.5+1.21.1] by Daedelus - [Architectury](https://architectury.github.io/architectury-documentations/) [13.0.6] by shedaniel - [Better End](https://modrinth.com/mod/betterend) [21.0.11] by Quiqueck (code), paulevs (code & art), Bulldog83 (code & art), Edos (building), Yuki (art), Seaward (art), Firel (music) - [Better Nether](https://www.curseforge.com/minecraft/mc-mods/betternether) [21.0.11] by quiqueck, paulevs (original author) - [CalcMod](https://github.com/js802025/calcmod) [1.3.2+fabric.1.21] by js802025, shadeydo - BadOptimizations [2.1.4] by Thosea - [Jade](https://www.curseforge.com/minecraft/mc-mods/jade) [15.4.1+fabric] by Snownee - [Lithium](https://jellysquid.me/projects/) [0.13.0] by JellySquid, 2No2Name - [Trinkets](https://www.curseforge.com/minecraft/mc-mods/trinkets-fabric) [3.10.0] by Emi, C4 - [JamLib](https://github.com/JamCoreModding/jamlib) [1.0.11+1.21] by Jamalam - [Xaero's Minimap](https://www.curseforge.com/minecraft/mc-mods/xaeros-minimap) [24.4.0] by xaero96 - [Entity Texture Features](https://www.curseforge.com/minecraft/mc-mods/entity-texture-features-fabric) [6.2.4] by Traben - Rogues & Warriors (RPG Series) [2.0.1+1.21.1] by Daedelus - [Cloth Config v15](https://minecraft.curseforge.com/projects/cloth-config) [15.0.140] by shedaniel - [Player Animator](kosmx.dev) [2.0.0-alpha1+1.21] by KosmX - [Capes](https://www.curseforge.com/minecraft/mc-mods/capes) [1.5.4+1.21] by Cael - [Iris](https://github.com/IrisShaders/Iris) [1.8.0-beta.4+mc1.21.1] by coderbot, IMS212, Justsnoopy30, FoundationGames - [Sodium Leaf Culling](https://github.com/txnimc/SodiumLeafCulling/) [1.0.0] by toni - [Simple Voice Chat](https://modrepo.de/minecraft/voicechat/overview) [1.21.1-2.5.22] by Max Henkel - Chat Heads [0.13.1] by dzwdz, Fourmisain - [MacOS Input Fixes](https://github.com/hamarb123/MCMacOSInputFixes) [1.7] by hamarb123 - [GeckoLib 4](https://www.curseforge.com/minecraft/mc-mods/geckolib) [4.6.5] by Gecko, Eliot, AzureDoom, DerToaster, Tslat, Witixin - [Bridging Mod](https://github.com/CloudG360/BridgingMod) [2.4.0+1.21] by CG360 - [Enhanced Block Entities](https://github.com/FoundationGames/EnhancedBlockEntities) [0.10.1+1.21] by FoundationGames - Spell Power Attribute [1.0.5+1.21.1] by Daedelus - YOSBR [0.1.2] by shedaniel - [Sodium Extra](https://modrinth.com/mod/sodium-extra) [0.6.0-beta.2+mc1.21.1] by FlashyReese - [Fabric Language Kotlin](https://minecraft.curseforge.com/projects/fabric-language-kotlin) [1.12.1+kotlin.2.0.20] by FabricMC I can imagine potentially one of the rendering mods I'm using being an issue - when I have some spare time, I'll double check to see if this repros without this :)

Crash report or logs

Kotori316 commented 1 month ago

I pass the "fixed" light to renderer, but I should get the light value for each position. I don't think getting light value for all position arm exists in every subticks is light, but I'll see.