Kotti / deform_bootstrap

Bootstrap compatible templates for the deform form library. (Merged into deform 2.)
http://pypi.python.org/pypi/deform_bootstrap
34 stars 30 forks source link

Support for Chosen #16

Closed mmariani closed 12 years ago

mmariani commented 12 years ago

This patch includes chosen 0.9.7 and two new widgets, that do not replace the standard ones. No readonly templates or selenium tests are provided.

dnouri commented 12 years ago

Looks very nice. Any chance we could get a Selenium test to go along with it? :-)

mmariani commented 12 years ago

maybe, not today. this selenium thing is new to me :)

dnouri commented 12 years ago

OK let me know if you need any help. There's instructions on how to set up Selenium and test the demo in the deformdemo package and in deform_bootstrap's README.

mmariani commented 12 years ago

I have added some tests now, though.. how am I supposed to check for the capture of an unordered set? I also did not rebuild deform_bootstrap.css from less.

dnouri commented 12 years ago

I'm afraid I don't know what you're referring to. Can you give a concrete example for your problem?

mmariani commented 12 years ago

self.assertSimilarRepr(captured, "{'countries': set(['EE', 'BG', 'IE'])}")

the results are not guaranteed to be in any specific order.

dnouri commented 12 years ago

You could eval it and compare:

>>> eval("{'countries': set(['EE', 'BG', 'IE'])}") == {'countries': set(['EE', 'BG', 'IE'])}
True
mmariani commented 12 years ago

ok, done

dnouri commented 12 years ago

Thanks a lot for this!