search

Kotti / deform_bootstrap

Bootstrap compatible templates for the deform form library. (Merged into deform 2.)
http://pypi.python.org/pypi/deform_bootstrap
34 stars 30 forks source link

Update to bootstrap 3 #66

Closed hariharan-uno closed 10 years ago

hariharan-uno commented 11 years ago

As bootstrap3 was released long back, i think it will be good if this project is updated to bs3.

dairiki commented 11 years ago

The latest alpha release of deform (2.0a1) uses bootstrap 3.

scott2b commented 10 years ago

Although, it does not seem like all widgets have been updated to bootstrap 3. E.g. CheckedPassword does not seem to render correctly. Is there a list of which widgets have been updated in 2.0a1?

dairiki commented 10 years ago

I don't know if there’s a list, but there is the demo. In my experience, deform2 is not yet always the prettiest, but it is mostly functional at this point.

Pull requests, discussion & grumblings about bs3 in deform should probably be directed at deform rather than deform_bootstrap since that's where the effort will be going. (And remember, the 'a' in 2.0a1 does mean 'alpha'.)

disko commented 10 years ago

Referring to the discussion on https://github.com/Kotti/Kotti/pull/277, deform_bootstrap won't be updated to Bootstrap 3 as deform 2 is already based on that itself. This makes deform_bootstrap redundant.

scott2b commented 10 years ago

Didn't mean to come across as grumbling. Just a point of clarification of expectations. Also, I guess I didn't realize that bootstrap 3 rendering was being done in deform itself. Thanks for the reply.

disko commented 10 years ago

Didn't mean to come across as grumbling.

You didn't! Apologies if I sounded harsh, English isn't my mother tongue. ;)

I didn't close the issue due to unwillingness to deal with, but just because deform 2 already does everything that's discussed here.

dairiki commented 10 years ago

@scott2b NP. Sorry if I came across as snarky. (English is my mother tongue — that doesn’t mean I’m always good at it.)

scott2b commented 10 years ago

ha, no. It's all good. Thanks again!