search

Koulio / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

404 error when trying to view side-by-side diff for issue 6256 #52

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?

1. http://codereview.appspot.com/6256/diff/1/3

or

1. http://codereview.appspot.com/6256
2. Click on 'View' for ipaddr.py

What is the expected output? What do you see instead?

I expect a side-by-side diff of ipaddr.py.  Instead, I'm getting a plain
"404 Not Found".

Please provide any additional information below.

Using Rietveld to review code for the ipaddr-py project at
http://ipaddr-py.googlecode.com/.  The first issue we created for the
project worked fine.  We're seeing unified diffs.

Original issue reported on code.google.com by sm...@google.com on 29 Sep 2008 at 1:57

GoogleCodeExporter commented 9 years ago 
It looks like the SVN base URL is wrong. It has a duplicate "trunk/" fragment...
Did you use the upload.py script to upload your patch or the web form?

Original comment by albrecht.andi on 29 Sep 2008 at 2:04

GoogleCodeExporter commented 9 years ago 
I used the web form. The diff was generated manually with an 'Svn diff'.

Original comment by Mr.D.Har...@gmail.com on 29 Sep 2008 at 2:26

GoogleCodeExporter commented 9 years ago 
There are two problems here:

1) The SVN base URL is wrong, the second "trunk/" fragment should be removed 
(use
"Edit Issue" to change the base URL).

2) The diff seems to be broken: It states to compare revision 1 with the working
copy, but both files don't exist in revision 1 (that causes a 404 too).

Original comment by albrecht.andi on 29 Sep 2008 at 3:50

GoogleCodeExporter commented 9 years ago 
I have reattempted with the upload.py file under a new issue number (5733) and 
this
has worked OK (upload.py created the svn diff).

In this case the SVN base now refers to my local ipaddr SVN tree:
 - file:///Users/harro/Source/ipaddr/

The raw patch file still refers to comparing revision 'one' with the 'working 
copy',
so this does not appear to be the issue.

We can close this issue as I am happy to work with the upload.py.

Original comment by Mr.D.Har...@gmail.com on 30 Sep 2008 at 1:17

GoogleCodeExporter commented 9 years ago

Original comment by gvanrossum@gmail.com on 30 Sep 2008 at 3:35