search

Koulio / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

Rietveld ignores files created by `svn cp` #82

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Check out Python's trunk: `svn co
http://svn.python.org/projects/python/trunk`.
2. Run `svn cp http://svn.python.org/projects/python/branches/py3k/setup.py
test_test_test`
3. Notice that `svn st` says "A  +   test_test_test" and that `svn diff
test_test_test` produces no output.
4. Modify README to simulate a real change: `echo Changed >> README`
5. Run upload.py
6. The resulting issue, http://codereview.appspot.com/14047, is missing the
test_test_test file with no indication that the reviewer should look at it
manually.

What is the expected output? What do you see instead?
I expect to see all files that were added listed in the files list. I'm not
sure if this is a subversion bug or Rietveld, but it'd be nice if Rietveld
could work around it.

What version of the product are you using? On what operating system?
I'm using svn 1.5.1, and I downloaded the upload.py script on 2009-02-03.

Original issue reported on code.google.com by jyass...@gmail.com on 3 Feb 2009 at 11:46

GoogleCodeExporter commented 9 years ago 
I think that only happens when a file is copied from a remote location. In that 
case
the file isn't listed in the diff produced by svn, not even with a property 
change
like it is for files copied from local source.

A possible solution would be to look at the output of "svn st" and manually add 
an
Index line to the generated diff if a file with "A  + " is listed in the status
output, but not in the diff. But I'm not sure if the diff applies correctly 
then if
it's downloaded from the review server (maybe it's the same as with a 
svn-generated
diff that lists a file copied from a local source).

Original comment by albrecht.andi on 4 Feb 2009 at 7:17

GoogleCodeExporter commented 9 years ago 
An additional note on this topic: That only seems to happen, when the file is 
copied
remotely from the same repository as the checkout.

Original comment by albrecht.andi on 11 Apr 2009 at 7:09

GoogleCodeExporter commented 9 years ago 
This appears happen for "svn move" as well, since that's a glorified "svn copy".

Original comment by widdow...@gmail.com on 17 Aug 2009 at 4:04

GoogleCodeExporter commented 9 years ago 
Confirming this also happens with "svn move" - destination file is absent from 
review.

Original comment by techtonik@gmail.com on 24 Aug 2010 at 4:59

GoogleCodeExporter commented 9 years ago

Original comment by techtonik@gmail.com on 27 Sep 2010 at 5:32

GoogleCodeExporter commented 9 years ago

Original comment by albrecht.andi on 6 Apr 2012 at 6:14